Underline links on hover by default #8544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Note: this is on staging right now. |
isoos
approved these changes
Feb 10, 2025
Collaborator
|
I've found the underline a bit harsh - I guess I'm used to using the site without it. Maybe we could have a different underline color using https://developer.mozilla.org/en-US/docs/Web/CSS/text-decoration-color ? |
jonasfj
approved these changes
Feb 10, 2025
Member
jonasfj
left a comment
jonasfj
left a comment
There was a problem hiding this comment.
Let's land this after the release on Wednesday, just to derisk a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart.dev and docs.flutter.dev updated to do this for most links as well to meet the requirement of using more than color to distinguish link interactivity.
Resolves #7391